Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

Fix/smart banner appid switch #646

Merged
merged 4 commits into from
Feb 9, 2017
Merged

Fix/smart banner appid switch #646

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7aaa1e2
Switched around the meta names for the app IDs
umarsheikh13 Feb 9, 2017
96d3636
Merge branch 'master' of https://github.com/quran/quran.com-frontend …
umarsheikh13 Feb 9, 2017
316fe07
Close and install onclick event handlers are now working
umarsheikh13 Feb 9, 2017
37dc5ab
Fixed issue of this being expected in hide/show methods
umarsheikh13 Feb 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/components/SmartBanner/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,13 @@ class SmartBanner extends Component {
const mixins = {
ios: {
icon: 'app-banner-ios.jpg',
appMeta: 'google-play-app',
appMeta: 'apple-itunes-app',
getStoreLink: () =>
`https://itunes.apple.com/${this.props.appStoreLanguage}/app/id`,
},
android: {
icon: 'app-banner-android.png',
appMeta: 'apple-itunes-app',
appMeta: 'google-play-app',
getStoreLink: () =>
'http://play.google.com/store/apps/details?id=',
}
Expand Down Expand Up @@ -178,7 +178,7 @@ class SmartBanner extends Component {
<a
tabIndex="-1"
className="smartbanner-close"
onClick={this.close}
onClick={() => this.close()}
data-metrics-event-name="SmartBanner:close"
>
<i className="fa fa-times-circle" />
Expand All @@ -190,7 +190,7 @@ class SmartBanner extends Component {
<span>{inStore}</span>
</div>

<a href={link} onClick={this.install} className="smartbanner-button" data-metrics-event-name="SmartBanner:InstallAapp">
<a href={link} onClick={() => this.install()} className="smartbanner-button" data-metrics-event-name="SmartBanner:InstallAapp">
<span className="smartbanner-button-text">{this.props.button}</span>
</a>
</div>
Expand Down