Tooling cleanup

[ahmedelgabri]

• remove ranges from package.json
• npm scripts adds executables form the node_modules folder in $PATH automatically so you can just reference the executable only without the path
• fix .stylelintrc indentation
• cleanup ESLint errors in webpack/ folder

[mmahalwy]

Problem coming from phantomjs

Would you mind updating our phantomjs package?

[ahmedelgabri]

@mmahalwy That's not phamtomjs problem it's a node-sass issue. Updated it.

Also, updated how travis pickup the right node version since it was using node 5

[ahmedre]

jenkins does use 6.3 (it uses the same configuration as the Dockerfile).

complaint from Jenkins is:

> [email protected] build:client /quran
> node webpack --config webpack/prod.config.js

module.js:442
    throw err;
    ^

Error: Cannot find module '/quran/webpack'
    at Function.Module._resolveFilename (module.js:440:15)
    at Function.Module._load (module.js:388:25)
    at Module.runMain (module.js:575:10)
    at run (bootstrap_node.js:352:7)
    at startup (bootstrap_node.js:144:9)
    at bootstrap_node.js:467:3

jenkins build using prod.

[ahmedelgabri]

Thanks for posting this because I can't see the errors myself, will have a look at this tomorrow.

[ahmedre]

i prefer putting 6.3.0 here instead of .nvmrc just because it will save a lot of pain in the future (next time Travis breaks, people will immediately open .travis.yml, and it may not be obvious to someone else that they need to look at .nvmrc).

[ahmedelgabri]

We can add a comment too saying that the node version is handled in .nvmrc.

Also most of the time travis breaks it will be something else plus travis already shows the version in the log & also that it picks it up from nvm.

I'm planning to make the tools & build process more robust so that things doesn't break unless it's something major.

[ahmedre]

Deployed to: http://staging.quran.com:32839

[ahmedre]

Deployed to: http://staging.quran.com:32840

[ahmedre]

Deployed to: http://staging.quran.com:32841

[thabti]

Looks good to me. let me know if this is ready to be merged.

[mmahalwy]

technically, we should eventually add --production to it. So we aren't downloading unneeded dependencies like phantomjs or karma

[ahmedelgabri]

True, but then travis will fail because the karma test that runs on travis requires phantomjs

[ahmedre]

Deployed to: http://staging.quran.com:32845

[ahmedelgabri]

@sabeurthabti It's ok form my side too, but to be sure I will just do one last check today afternoon.

[ahmedre]

Deployed to: http://staging.quran.com:32846

[ahmedelgabri]

@sabeurthabti You can merge this now. I'll follow up with a new PR to do more cleanup, but for now this is good to go 👍

[thabti]

lgtm

[thabti]

Thank you @ahmedelgabri

[mmahalwy]

Thanks @ahmedelgabri !