Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve alias remapping #649

Merged
merged 1 commit into from
May 2, 2023
Merged

Improve alias remapping #649

merged 1 commit into from
May 2, 2023

Conversation

TobiasFella
Copy link
Member

  • Don't print a warning if an alias is remapped from a room to its replacement room
  • Don't remap aliases from the new room to the old room
    (I've never noticed any problems caused by this, but the log message is slightly annoying)

- Don't print a warning if an alias is remapped from a room to its replacement room
- Don't remap aliases from the new room to the old room
@sonarcloud
Copy link

sonarcloud bot commented Apr 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TobiasFella
Copy link
Member Author

Sonar complains about "code complexity"; should i refactor the code a bit?

@KitsuneRal
Copy link
Member

TL;DR: No; it's Sonar's fault, not ours.

I found some time ago that Sonar spins up complexity on every qC* macro (you can see it in the issue details). I used to switch to their q* counterparts in the past to avoid it (they also allow to specify logging categories since Qt 5.12 or something). I don't practice it any more because, as I mentioned in the chat one day, qC* versions force you to provide a category (a good thing) while q* don't; and this is more valuable than trying to go around quirks of a static analysis tool.

And after digging up stuff recently I learnt that Sonar actually tried to fix this very issue as long ago as in 2018 - yet somehow it's still here. Looking at the way it was fixed, I can imagine it still tries to account for "generated code" (as it's called inside Sonar codebase) in some place - so, see TL:DR.

@KitsuneRal KitsuneRal merged commit 51da171 into dev May 2, 2023
@TobiasFella TobiasFella deleted the tobias/alias-remapping branch July 13, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants