Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve native data update logic and triggers #525

Merged
merged 6 commits into from
Aug 6, 2023
Merged

refactor: improve native data update logic and triggers #525

merged 6 commits into from
Aug 6, 2023

Conversation

ACTCD
Copy link
Collaborator

@ACTCD ACTCD commented Aug 4, 2023 •
edited
Loading

Migrate popup init checks logic to background page.

Added:

Improve the prompt to open popup when first time of installed in iOS
popup_first_time.mp4

@ACTCD ACTCD requested a review from quoid August 4, 2023 03:49
@ACTCD ACTCD marked this pull request as draft August 4, 2023 04:20
@ACTCD ACTCD marked this pull request as ready for review August 4, 2023 22:03
quoid
quoid approved these changes Aug 5, 2023
View reviewed changes
Copy link
Owner

@quoid quoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, very nice improvements

@ACTCD ACTCD merged commit b762151 into main Aug 6, 2023
1 check passed
@ACTCD ACTCD deleted the native_update_logic branch August 6, 2023 21:52
@ACTCD ACTCD restored the native_update_logic branch August 6, 2023 21:55
@ACTCD ACTCD deleted the native_update_logic branch August 6, 2023 21:55
@ACTCD ACTCD mentioned this pull request Sep 10, 2023
Merged
@ACTCD ACTCD mentioned this pull request Oct 15, 2023
Open
@ACTCD ACTCD mentioned this pull request Mar 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quoid quoid quoid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Required resources do not update
2 participants
@ACTCD @quoid