-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Add version release number in unreleased docs #1621
Conversation
Perfect. Thank you! |
@ventuno Looks like it didn't go exactly as planned. The link at https://api.qunitjs.com/QUnit/test.each/ is now a 404 Error, looking for Could you take another look? I think it would be tricky to handle this in the build script since from its perspective there is no right answer (stripping the patch number unconditionally means it would link to the wrong version if something did get released in a patch version, stripping the patch number only if it is Perhaps we can embrace the way you did it here and update the markdown files to use the fulll version instead. That seems simpler in the long run. If you go that route, remember to also update |
@Krinkle sorry if this introduced an issue. I now see how existing |
@ventuno Yep, no problem! |
``` broken: 3 --- - code: 404 url: https://github.com/qunitjs/qunit/releases/tag/2.1 parent: https://api.qunitjs.com/config/QUnit.push/ error: Not Found - code: 404 url: https://github.com/qunitjs/qunit/releases/tag/2.12 parent: https://api.qunitjs.com/config/QUnit.extend/ error: Not Found - code: 404 url: https://github.com/qunitjs/qunit/releases/tag/unversioned parent: https://api.qunitjs.com/config/QUnit.onUncaughtException/ error: Not Found ``` Ref #1625. Ref #1621.
The grep command exits non-zero if there are no matches. Default to an empty array so that the prep continues. Ref #1621.
The grep command exits non-zero if there are no matches. Default to an empty array so that the prep continues. Ref #1621.
Following up on this conversation: replace "unreleased" with the version number in docs when releasing a new version.