Core: Only pass internal argument to test callback when using each() #1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This restores previous behaviour to avoid breaking plugins that might already extend or monkey-patch QUnit to add additional parameters to the test callback. Also: * Declare the params setting in the Test class for added clarity, and to ensure a consistent object shape. * Make more use of the new `addTest()` function that was added in #1569, this reduces a lot of duplication. While at it, I shifted the abstraction slightly to expose the Test class settings directly, thus making the `addTest()` mainly be responsible for the queuing and filtering, and no longer responsible for formatting the Test class settings. The use of ES2015 shorthand property name syntax makes feel almost identical to the function parameter signature.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores previous behaviour to avoid breaking plugins that might
already extend or monkey-patch QUnit to add additional parameters to
the test callback.
Also:
Declare the params setting in the Test class for added clarity, and to ensure a consistent object shape.
Make more use of the new
addTest()function that was added in Core: Add test.each. #1569, this reduces a lot of duplication. Thanks @ventuno!While at it, I shifted the abstraction slightly to expose the Test class settings directly, thus making the
addTest()mainlybe responsible for the queuing and filtering, and no longer responsible for formatting the Test class settings.
With the added use of ES2015 shorthand property name syntax, this feels almost identical using function parameters.