Assert: Introduce strict boolean assertions. #1445
Conversation
|
Looks good to me. I'll do a more close review of the source code later on, but let's get the docs in meanwhile as well? The docs use Jekyll and Markdown. See |
|
Thanks @Krinkle, just added docs for Let me know if you'd like me to make some changes to the documentation for |
|
Yep, my thoughts exactly. Let's tackle that separately. I'll try to review this PR soon :) Thanks! |
docs/assert/false.md
Outdated
|
|
||
| ## `false( state [, message ] )` | ||
|
|
||
| A boolean check, inverse of `true()` equivalent to Chais's `assert.isFalse()`, and JUnit's `assertFalse()`. Passes if the first argument is false. |
| categories: | ||
| - assert | ||
| redirect_from: | ||
| - "/true/" |
There was a problem hiding this comment.
Many files contain this for compat with URLs from an older iteration of the API doc site (which was based on WordPress and jquer-wp-content). Not needed for new pages. I'll omit this while landing.
|
|
||
| | name | description | | ||
| |--------------------|--------------------------------------| | ||
| | `state` | Expression being tested | |
There was a problem hiding this comment.
This is a left-over from ok(), for which in turn I actually don't know where it originates, but in general we call this the actual value. I'll use that here as well when landing the commit.
| | name | description | | ||
| |--------------------|--------------------------------------| | ||
| | state | Expression being tested | | ||
| | message (string) | A short description of the assertion | |
|
Thanks @Krinkle any idea when these changes will be released? |
|
@ventuno I'm aiming for within the next few weeks, in July? |
|
Sounds good. Thanks! |
|
I'd like to add types for these new assertions in @types/qunit: DefinitelyTyped/DefinitelyTyped#49911 |
|
@bmish Thanks. I've left a review over there, LGTM. Would you be interested in contributing type definitions into QUnit itself? |
Closes #1444.
TODO: