Tests: Add case for errors while console is mocked #1343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krinkle
force-pushed
the
mocked-console
branch
from
95645f7 to
433cbcd
Compare
The asserted output is not what we'd like it to be. This is just to document what happens today. Ref #1340.
Krinkle
force-pushed
the
mocked-console
branch
from
433cbcd to
3857c31
Compare
trentmwillis
approved these changes
Dec 24, 2018
|
I'll fix it together with the added test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The asserted output is not what we'd like it to be.
This is just to document what happens today.
Ref #1340.