Core: adds back running class to items and adds tests #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielcsapo
force-pushed
the
adds-running-class-and-tests
branch
from
1823961 to
79461de
Compare
trentmwillis
requested changes
Nov 1, 2018
test/reporter-html-running-class.js
Outdated
| @@ -0,0 +1,5 @@ | |||
| QUnit.module( "Ensure that html reporter adds running class", function() { | |||
There was a problem hiding this comment.
Thanks for adding a test! This, however, should probably go in the existing reporter-html test file: https://github.com/qunitjs/qunit/blob/master/test/reporter-html/reporter-html.js
There was a problem hiding this comment.
@trentmwillis good idea, just added the test there
gabrielcsapo
force-pushed
the
adds-running-class-and-tests
branch
from
79461de to
01a81ca
Compare
gabrielcsapo
force-pushed
the
adds-running-class-and-tests
branch
from
01a81ca to
fa1856e
Compare
trentmwillis
approved these changes
Nov 1, 2018
|
Thank you! |
Krinkle
added a commit
that referenced
this pull request
Jul 14, 2024
== Background In QUnit 1.16.0, as part of #677, commit 168b048 changed the testStart() callback to no longer always create `qunit-test-output-TESTID` with class "running", but instead eagerly create them ahead of time via a QUnit.begin() handler (without the "running" class), and then during testStart() set the class to "running", or lazily create the item then. This introduced a bug where, late-defined tests lack the "running" class. This bug then later spread to all items as we now treat all tests as late-defined. In QUnit 2.8.0, as part of #1323, this was attempted to be restored, but it added it to a different element, namely `#qunit-testresult-display` which from what I could find in our history, never previously carried this class. This might've been done by acciddent, but in any case, let's keep that. == What * Restore this to simplify the CSS, and makes it more developer-friendly to theme QUnit by not having to list all statuses, and/or having to use a direct-child selector like `#qunit-tests > li` to reliably select test items (and not other lists like the assertion list). * For back-compat, keep the running class on `qunit-testresult-display` but move it to onBegin() since there is no reason to set this again and again on every test since it never changes. * Document these bits in the recently created "Theme API" section.
Krinkle
added a commit
that referenced
this pull request
Jul 14, 2024
== Background In QUnit 1.16.0, as part of #677, commit 168b048 changed the testStart() callback to no longer always create `qunit-test-output-TESTID` with class "running", but instead eagerly create them ahead of time via a QUnit.begin() handler (without the "running" class), and then during testStart() set the class to "running", or lazily create the item then. This introduced a bug where, late-defined tests lack the "running" class. This bug then later spread to all items as we now treat all tests as late-defined. In QUnit 2.8.0, as part of #1323, this was attempted to be restored, but it added it to a different element, namely `#qunit-testresult-display` which from what I could find in our history, never previously carried this class. This might've been done by acciddent, but in any case, let's keep that. == What * Restore this to simplify the CSS, and makes it more developer-friendly to theme QUnit by not having to list all statuses, and/or having to use a direct-child selector like `#qunit-tests > li` to reliably select test items (and not other lists like the assertion list). * For back-compat, keep the running class on `qunit-testresult-display` but move it to onBegin() since there is no reason to set this again and again on every test since it never changes. * Document these bits in the recently created "Theme API" section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the running class was removed and no existing tests catch this, I added it back and now added with it a test to ensure this doesn't happen again.