Update fsevents subdependency for Node 10 compat

[Turbo87]

without this update node-gyp failed when running on Node 10.3.0

/cc @trentmwillis

[platinumazure]

Should there also be a change in package.json?

[rwjblue]

No, the change is already allowed by the current package.json range. But when you clone the repo and yarn it always gives you the previously locked down version.

[platinumazure]

@rwjblue Understood, but should we set the package.json to a higher version anyway so our dependency list avoids the problematic version even if yarn.lock were removed?

[Turbo87]

@platinumazure fsevents is just a subdependency of some other dependency, so there is no change in the package.json file. If you don't use a lockfile you would have gotten that update automatically, but since the lockfile also locks subdependencies they sometimes need to be updated too.

[Turbo87]

whoops, missed that @rwjblue had already replied.

fsevents is brought in by chokidar, and yes an update of that dependency would be good, but since their current version is 2.0.4 which has a major bump compared to the 1.7.0 we use, this is a slightly larger undertaking to upgrade.

[platinumazure]

Thanks, that answers my questions.

[trentmwillis]

Thanks!