Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable autocomplete on module search input #1277

Merged
merged 1 commit into from
May 7, 2018
Merged

fix: disable autocomplete on module search input #1277

merged 1 commit into from
May 7, 2018

Conversation

makepanic
Copy link
Contributor

fixes #1276

@jsf-clabot
Copy link

jsf-clabot commented May 2, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

platinumazure
platinumazure reviewed May 2, 2018
View reviewed changes
Copy link
Contributor

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

Waiting for another set of eyes on this in case any minor tweaks are needed to follow contribution guidelines (which I don't know as well as some of the others).

trentmwillis
trentmwillis approved these changes May 7, 2018
View reviewed changes
Copy link
Member

@trentmwillis trentmwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@trentmwillis trentmwillis merged commit 397c078 into qunitjs:master May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@platinumazure platinumazure platinumazure left review comments

@trentmwillis trentmwillis trentmwillis approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Browser autocomplete overlaps qunit module filter autocomplete
4 participants
@makepanic @jsf-clabot @platinumazure @trentmwillis