-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI --seed without value and files argument is counterintuitive #1691
Labels
Milestone
Comments
Approaches to consider:
After this, we'll want to improve the HTML Reporter and TAP Reporter, to present these to users to help reproduce a specific failure. |
Krinkle
added a commit
to Krinkle/qunit
that referenced
this issue
Sep 16, 2024
Krinkle
added a commit
to Krinkle/qunit
that referenced
this issue
Sep 16, 2024
Krinkle
added a commit
to Krinkle/qunit
that referenced
this issue
Sep 16, 2024
Krinkle
added a commit
that referenced
this issue
Dec 6, 2024
* Fix `--seed <file>` arg confusion. This is now correctly interpreted as a file. * Fix presence of "Running tests with seed:" message on CLI when preconfig qunit_config_seed is set via environment variable. Previously the seed was applied, but not printed because the printing logic only checked the CLI options, not QUnit.config. * Add `--seed=true` to generate a new seed. This is backported from QUnit 3.0.0-alpha, and aligns the CLI with what was already supported via Preconfig, QUnit.config, and URL params. Cherry-picked from 390a5b7 (3.0.0-dev). > Ref #1691.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using
qunit --seed
it will default to runningtest/**.js
and will print the randomly selected seed for future re-use. This works as expected:The problem is, when using a files argument, the command becomes ambiguous and it naturally becomes the value for the seed instead:
This can be worked around currently by using
--
to mark the end of the options and the start of the arguments:The text was updated successfully, but these errors were encountered: