Report affected modules for "hook called from wrong module" warning

[chriskrycho]

Currently, QUnit reports that a hook is called from the wrong module, but doesn't say which modules are affected:

qunit/src/module.js

Lines 114 to 118 in e457e29

	if ( config.currentModule !== module ) {
	Logger.warn( "The `" + hookName + "` hook was called inside the wrong module. " +
	"Instead, use hooks provided by the callback to the containing module. " +
	"This will become an error in QUnit 3.0." );
	}

—even though the information is attached to the module:

qunit/src/module.js

Line 28 in e457e29

name: moduleName,

This makes it quite difficult to figure out where the issue actually comes from. I'm happy to open a PR for this!

[Krinkle]

@chriskrycho Sounds good to me. Thanks!

[chriskrycho]

PR inbound later today or tomorrow!

[chriskrycho]

@Krinkle I've opened #1648 for this.

[Krinkle]

@chriskrycho Great.

Meanwhile, if I may ask, did you welcome this warning while writing a new test, or did it find you as a surprise after upgrading QUnit? This is a brand new warning we added, so we're certainly open to feedback or use cases you may have, which could influence how we proceed with this in QUnit 3.

[chriskrycho]

I noticed it in a large app (LinkedIn) when working on other tests. I think the warning is good; the only issue was this one. As you can imagine, when you have tens of thousands of tests, tracing back to individual modules is tricky without more info!