Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module dropdown in run order or sorted order? #1487

Closed
Krinkle opened this issue Oct 2, 2020 · 1 comment
Closed

Module dropdown in run order or sorted order? #1487

Krinkle opened this issue Oct 2, 2020 · 1 comment
Assignees
@Krinkle
Labels
Component: HTML Reporter Type: Enhancement New idea or feature request. Type: Meta Seek input from maintainers and contributors.

Comments

@Krinkle
Copy link
Member

Krinkle commented Oct 2, 2020 •
edited
Loading

As part of #1486 I noticed that since #973 the alpha-sorted modulesList variable is effectively no longer used. Instead, the dropdown menu reflects the order in which tests are registered and executed.

It's not clear to me whether this change was made intentionally. What do you think? Is it better to function as a table of contents and match the order of results on the page, or to function as its own (alpha) sorted index?

Note that parent/child modules will still remain together either way since we use the full name in this menu, which starts with Parent module > .
@Krinkle Krinkle added Component: HTML Reporter Type: Enhancement New idea or feature request. labels Oct 2, 2020
Krinkle added a commit that referenced this issue Oct 2, 2020
@Krinkle
HTML Reporter: Remove unused 'moduleList' arrray
5a05192 
Follows-up 0780127, which changed the code to use
QUnit.config.modules directly. This meant the list is no longer
sorted, however. I filed #1487
to look into that.

Depending on the outcome of that, we can bring this back in some form
after the refactoring of #1487.
@Krinkle Krinkle mentioned this issue Oct 2, 2020
Merged
Krinkle added a commit that referenced this issue Oct 2, 2020
@Krinkle
HTML Reporter: Remove unused 'moduleList' arrray
3092de3 
Follows-up 0780127, which changed the code to use
QUnit.config.modules directly. This meant the list is no longer
sorted, however. I filed #1487
to look into that.

Depending on the outcome of that, we can bring this back in some form
after the refactoring of #1487.
Krinkle added a commit that referenced this issue Nov 5, 2020
@Krinkle
HTML Reporter: Remove unused 'moduleList' array
c494fb8 
Follows-up 0780127, which changed the code to use
QUnit.config.modules directly. This meant the list is no longer
sorted, however. I filed #1487
to look into that.

Depending on the outcome of that, we can bring this back in some form
after the refactoring of #1487.
@Krinkle Krinkle added the Type: Meta Seek input from maintainers and contributors. label Nov 11, 2020
@Krinkle
Copy link
Member Author

Krinkle commented Apr 18, 2022

I'm considering this resolved after #1664 (comment) and #1685.

Basically, we now only show 20 items at most, and whenever something is typed in the field, the order is determined by fuzzysort ranking which is neither defined order nor alphabetical order.

For the initial 20 items, we simply take the first 20 that were defined which was simply the most efficient way to implement it. That could potentially be changed if there was interest, but I think for this issue it is resolved.

@Krinkle Krinkle closed this as completed Apr 18, 2022
@Krinkle Krinkle self-assigned this Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Krinkle Krinkle

Labels
Component: HTML Reporter Type: Enhancement New idea or feature request. Type: Meta Seek input from maintainers and contributors.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Krinkle