Skip to content

Commit

Permalink
Core: Unexpected test after runEnd is now an error
Browse files Browse the repository at this point in the history
Deprecated warning was added in 2.17.0.

Ref #1377.
Ref #1629.
  • Loading branch information
Krinkle committed Jun 1, 2024
1 parent cdab9e9 commit 77e7905
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions src/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,7 @@ export default function Test (settings) {
// (Meaning the CI would pass despite the late-failing test).
// Ref https://github.com/qunitjs/qunit/issues/1377
if (config.pq.finished) {
// TODO: Make this an error in QUnit 3.0
// throw new Error( 'Unexpected test after runEnd. To report errors, consider calling QUnit.onUncaughtException() instead.' );
Logger.warn('Unexpected test after runEnd. This is unstable and will fail in QUnit 3.0.');
return;
throw new Error( 'Unexpected test after runEnd. To report errors, consider calling QUnit.onUncaughtException() instead.' );
}
if (!this.skip && typeof this.callback !== 'function') {
const method = this.todo ? 'QUnit.todo' : 'QUnit.test';
Expand Down

0 comments on commit 77e7905

Please sign in to comment.