Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DAE-117] Add method to get partitions with name and type #53

Merged
merged 2 commits into from
Feb 25, 2021

Conversation

LucasMMota
Copy link
Contributor

@LucasMMota LucasMMota commented Feb 25, 2021

Why? πŸ“–

We need a method that returns the partitions names & types.

What? πŸ”§

Adding method get_partition_keys that gets the partition keys from a table as a tuple: (name, type).

Type of change πŸ—„οΈ

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How everything was tested? πŸ“

Unit tests + testing with Hive metastore server.

Checklist πŸ“

  • I have added labels to distinguish the type of pull request.
  • My code follows the style guidelines of this project (docstrings, type hinting and linter compliance);
  • I have performed a self-review of my own code;
  • I have made corresponding changes to the documentation;
  • I have added tests that prove my fix is effective or that my feature works;
  • I have made sure that new and existing unit tests pass locally with my changes;

@LucasMMota LucasMMota added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 25, 2021
@LucasMMota LucasMMota self-assigned this Feb 25, 2021
@LucasMMota LucasMMota requested a review from a team as a code owner February 25, 2021 18:26
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@LucasMMota LucasMMota merged commit 220e8e3 into main Feb 25, 2021
@LucasMMota LucasMMota deleted the lucasmendes/dae-117 branch February 25, 2021 18:47
@LucasMMota LucasMMota mentioned this pull request Feb 26, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants