Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DAE-116] Add method bulk drop #49

Merged
merged 5 commits into from
Feb 23, 2021
Merged

Conversation

LucasMMota
Copy link
Contributor

@LucasMMota LucasMMota commented Feb 19, 2021

Why? 📖

We don't have a method to drop all partitions at once.
So to keep the interface cleaner for the lib's users we decided to add a method that encapsulates the behavior of dropping each partition from a list.

What? 🔧

Add method bulk_drop_partitions

Type of change 🗄️

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Release

How everything was tested? 📏

Unit tests

Checklist 📝

  • I have added labels to distinguish the type of pull request.
  • My code follows the style guidelines of this project (docstrings, type hinting and linter compliance);
  • I have performed a self-review of my own code;
  • I have made corresponding changes to the documentation;
  • I have added tests that prove my fix is effective or that my feature works;
  • I have made sure that new and existing unit tests pass locally with my changes;

@LucasMMota LucasMMota added the enhancement New feature or request label Feb 19, 2021
@LucasMMota LucasMMota requested a review from a team as a code owner February 19, 2021 21:35
@LucasMMota LucasMMota self-assigned this Feb 19, 2021
@LucasMMota LucasMMota changed the title [DAE-93] Add method bulk drop [DAE-93][DAE-116] Add method bulk drop Feb 19, 2021
@LucasMMota LucasMMota force-pushed the dae-93-bulk-drop-partitions branch from fcfbba8 to 72458d9 Compare February 23, 2021 13:56
@LucasMMota LucasMMota changed the title [DAE-93][DAE-116] Add method bulk drop [DAE-116] Add method bulk drop Feb 23, 2021
@LucasMMota LucasMMota requested a review from a team as a code owner February 23, 2021 17:39
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@LucasMMota LucasMMota merged commit 83d4b46 into main Feb 23, 2021
@LucasMMota LucasMMota deleted the dae-93-bulk-drop-partitions branch February 23, 2021 17:42
@felipemiquelim felipemiquelim mentioned this pull request Feb 23, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants