Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DF-316] Fix type in hive_metastore_client.py file name #33

Merged
merged 3 commits into from
Dec 11, 2020
Merged

[DF-316] Fix type in hive_metastore_client.py file name #33

merged 3 commits into from
Dec 11, 2020

Conversation

LucasMMota
Copy link
Contributor

Why? 📖

According to issue #31 there was a typo in the file name.

What? 🔧

  • Refactor file name and references

Type of change 🗄️

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How everything was tested? 📏

  • Unit tests + local run

Checklist 📝

  • I have added labels to distinguish the type of pull request.
  • My code follows the style guidelines of this project (docstrings, type hinting and linter compliance);
  • I have performed a self-review of my own code;
  • I have made corresponding changes to the documentation;
  • I have added tests that prove my fix is effective or that my feature works;
  • I have made sure that new and existing unit tests pass locally with my changes;

@LucasMMota LucasMMota added the bug Something isn't working label Dec 11, 2020
@LucasMMota LucasMMota requested a review from a team as a code owner December 11, 2020 14:36
@LucasMMota LucasMMota self-assigned this Dec 11, 2020
felipemiquelim
felipemiquelim previously approved these changes Dec 11, 2020
View reviewed changes
@LucasMMota LucasMMota changed the title Fix type in hive_metastore_client.py file name [DF-316] Fix type in hive_metastore_client.py file name Dec 11, 2020
@LucasMMota LucasMMota force-pushed the lucasmmota/issue-31-wrong-file-name branch from 361b13c to 9a5ce8a Compare December 11, 2020 14:44
felipemiquelim
felipemiquelim previously approved these changes Dec 11, 2020
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@LucasMMota LucasMMota merged commit d007256 into main Dec 11, 2020
@LucasMMota LucasMMota deleted the lucasmmota/issue-31-wrong-file-name branch December 11, 2020 16:51
@felipemiquelim felipemiquelim mentioned this pull request Dec 11, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipemiquelim felipemiquelim felipemiquelim approved these changes

Assignees

@LucasMMota LucasMMota

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucasMMota @felipemiquelim