Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DF-295] Adding method to add columns to a table #18

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Conversation

jufreire
Copy link
Contributor

@jufreire jufreire commented Dec 1, 2020

Why? 📖

We want to encapsulate logic to add columns to a table in hive using thrift client classes.

What? 🔧

  • Added add_columns_to_table method in HiveMetastoreClient to encapsulate logic of get table object representation from hive, add columns to the list of columns and call alter table to add the new columns.
  • Added example on how to use the add_columns_to_table method.
  • Added unit tests.

Type of change 🗄️

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How everything was tested? 📏

Running locally and with unit tests.

Checklist 📝

  • I have added labels to distinguish the type of pull request.
  • My code follows the style guidelines of this project (docstrings, type hinting and linter compliance);
  • I have performed a self-review of my own code;
  • I have made corresponding changes to the documentation;
  • I have added tests that prove my fix is effective or that my feature works;
  • I have made sure that new and existing unit tests pass locally with my changes;

@jufreire jufreire added the enhancement New feature or request label Dec 1, 2020
@jufreire jufreire requested a review from a team as a code owner December 1, 2020 15:09
@jufreire jufreire self-assigned this Dec 1, 2020
Copy link
Contributor

@LucasMMota LucasMMota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This was referenced Dec 2, 2020
@jufreire jufreire merged commit 0325ace into main Dec 2, 2020
@jufreire jufreire deleted the DF-295 branch December 2, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants