-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't allow small units of application data to keep large packets in memory #431
Comments
Something to consider if exceptionally unreasonable packet constructions are detected, although we probably want to be forgiving of mildly buggy QUIC implementations. |
@carllerche has discussed the possibility of using |
Quinn uses zero-copy refcounted
Bytes
for most processing of incoming data. At the extreme, a hostile peer could send numerous stream frames containing a single byte in a packet padded to MTU size. We could combat this by heuristically opting to copy segments of application data into freshly allocated memory when they fall below a certain proportion of the packet, or when a packet consists of a small proportion of application data, or similar.The text was updated successfully, but these errors were encountered: