Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image to build for Python 3.8 #8

Merged
merged 8 commits into from
Sep 4, 2021
Merged

Update image to build for Python 3.8 #8

merged 8 commits into from
Sep 4, 2021

Conversation

akarve
Copy link
Member

@akarve akarve commented Sep 1, 2021

No description provided.

@akarve akarve marked this pull request as ready for review September 1, 2021 22:06
Dockerfile Outdated
zip \
&& yum clean all

RUN update-alternatives --install /usr/bin/python3 python3 /usr/bin/python3.8 1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we want a default higher priority.

Suggested change
RUN update-alternatives --install /usr/bin/python3 python3 /usr/bin/python3.8 1
RUN update-alternatives --install /usr/bin/python3 python3 /usr/bin/python3.8 10

Copy link
Member

@sir-sigurd sir-sigurd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use one of these or these images?

@akarve
Copy link
Member Author

akarve commented Sep 2, 2021

Can't we use one of these or these images?

Done and that's a better solution. I actually looked for these images and didn't find them at first. Googling "amazon lambda docker image" is not very useful but "amazon lambda docker hub image" gets you to the right place. Happens to be a separate repo from amazon-linux 2.

@akarve akarve requested a review from sir-sigurd September 2, 2021 21:14
Copy link
Contributor

@dimaryaz dimaryaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, assuming it works - but curious where rapid-client came from.

requirements.txt Outdated Show resolved Hide resolved
@akarve akarve requested a review from dimaryaz September 4, 2021 00:57
@akarve akarve merged commit 0dcee3b into master Sep 4, 2021
@akarve akarve deleted the python38 branch September 4, 2021 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants