Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AEAD limits for larger packets #4175
Update AEAD limits for larger packets #4175
Changes from 1 commit
ef94ae1
551184a
5280b95
feff732
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to call this out. @chris-wood, can you check that this is right here? I think that this comes from the
\sigma*B/2^n
term in Bad3 in the paper, but I want to make sure that my understanding is correct in that we are treating\sigma*B
as\sigma^2
in the single-user case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or "targeted"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to say that the "value of the goal" is the same. I think that this is correct.
I think that you might say "target advantages for A and B", but I think that "advantages" means something else and so I avoided the plural.
Maybe instead "As the target for both the confidentiality advantage and integrity advantage is the same, ..." ?
My grammar skillz aren't up to this, clearly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or plural works in that last arrangement, so "As the targets for the confidentiality advantage and the integrity advantage are the same...." I think any of them are fine, so long as they agree in number. What stuck out to me was "targets advantage" more than anything else.