Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename SERVER_BUSY to CONNECTION_REFUSED #3694

Merged
merged 1 commit into from
May 27, 2020

Conversation

kazuho
Copy link
Member

@kazuho kazuho commented May 25, 2020

Please see the discussion on #3690 for the rationale, but in short, SERVER_BUSY is renamed as CONNECTION_REFUSED. A server might refuse a connection for various reasons. SERVER_BUSY is one specific reason. Having an error code for that specific case while not having an error code for generic case is awkward. Hence the rename.

Closes #3690.

@martinthomson martinthomson added -transport editorial An issue that does not affect the design of the protocol; does not require consensus. labels May 26, 2020
@martinthomson martinthomson merged commit 4134402 into quicwg:master May 27, 2020
@marten-seemann
Copy link
Contributor

marten-seemann commented May 27, 2020

I'm not sure if this was an editorial PR. The previous text talked about a situation where a server was too busy to accept a new connection. The new text generalizes this to a connection refusal for any reason. That's a design change.

I also strongly disagree that this issue should close #3690. There's still on ongoing discussion if an additional error code should be introduced. I can't see how this is not a design issue.

@MikeBishop
Copy link
Contributor

There was previously no requirement to send this error code under any particular circumstances nor any requirement to take action upon receipt of this error code, and therefore those requirements cannot have been changed. This modifies the prose around an error code the server could use to reject a connection attempt to make the recommendation more narrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to reject a connection attempt
6 participants