check unsupported parameters top_hits

quickwit-oss · Apr 9, 2024 · d0aa9e2 · d0aa9e2
1 parent 1e9fc51
commit d0aa9e2
Showing 1 changed file with 45 additions and 0 deletions.
diff --git a/src/aggregation/metric/top_hits.rs b/src/aggregation/metric/top_hits.rs
@@ -13,6 +13,7 @@ use crate::aggregation::intermediate_agg_result::{
     IntermediateAggregationResult, IntermediateMetricResult,
 };
 use crate::aggregation::segment_agg_result::SegmentAggregationCollector;
+use crate::aggregation::AggregationError;
 use crate::collector::TopNComputer;
 use crate::schema::term::JSON_PATH_SEGMENT_SEP_STR;
 use crate::schema::OwnedValue;
@@ -96,6 +97,14 @@ pub struct TopHitsAggregation {
     #[serde(rename = "docvalue_fields")]
     #[serde(default)]
     doc_value_fields: Vec<String>,
+
+    // Not supported
+    _source: Option<serde_json::Value>,
+    fields: Option<serde_json::Value>,
+    script_fields: Option<serde_json::Value>,
+    highlight: Option<serde_json::Value>,
+    explain: Option<serde_json::Value>,
+    version: Option<serde_json::Value>,
 }
 
 #[derive(Debug, Clone, PartialEq, Default)]
@@ -148,6 +157,42 @@ impl TopHitsAggregation {
         &mut self,
         reader: &ColumnarReader,
     ) -> crate::Result<()> {
+        let use_doc_value_fields_err = |parameter: &str| {
+            Err(crate::TantivyError::AggregationError(
+                AggregationError::InvalidRequest(format!(
+                    "The `{}` parameter is not supported, only `docvalue_fields` is supported in \
+                     `top_hits` aggregation",
+                    parameter
+                )),
+            ))
+        };
+        if self._source.is_some() {
+            use_doc_value_fields_err("_source")?;
+        }
+        if self.fields.is_some() {
+            use_doc_value_fields_err("fields")?;
+        }
+        if self.script_fields.is_some() {
+            use_doc_value_fields_err("script_fields")?;
+        }
+        let unsupported_err = |parameter: &str| {
+            Err(crate::TantivyError::AggregationError(
+                AggregationError::InvalidRequest(format!(
+                    "The `{}` parameter is not supported in the `top_hits` aggregation",
+                    parameter
+                )),
+            ))
+        };
+        if self.explain.is_some() {
+            unsupported_err("explain")?;
+        }
+        if self.highlight.is_some() {
+            unsupported_err("highlight")?;
+        }
+        if self.version.is_some() {
+            unsupported_err("version")?;
+        }
+
         self.doc_value_fields = self
             .doc_value_fields
             .iter()