-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable lsm unbond #997
Disable lsm unbond #997
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #997 +/- ##
==========================================
- Coverage 61.78% 61.44% -0.35%
==========================================
Files 172 172
Lines 14134 14118 -16
==========================================
- Hits 8733 8675 -58
- Misses 4651 4697 +46
+ Partials 750 746 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Do you think this should result in any upstream fixes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch we love to live reliable
No, just LSM unbonding is a much more complex math problem, as the user receives bonded tokens back, and you need to compromise somewhere between what is best for the protocol, and what is best for the user (not receiving buckets of dust). It requires a little more finesse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finesse
Remove LSM unbonding given it's unreliability, and always use native unbonding.