Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow chainId without hyphen. Fixes #974 #976

Merged
merged 3 commits into from
Dec 29, 2023

Conversation

joe-bowman
Copy link
Contributor

1. Summary

Fixes #974

Remove the requirement for a chainId to contain a hyphen.

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

3. Implementation details

Remove ValidateBasic checks that reject chainids without hyphens, to support provider and celestia.

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (385906d) 61.85% compared to head (509c0ce) 61.81%.
Report is 1 commits behind head on main.

❗ Current head 509c0ce differs from pull request most recent head aa116ad. Consider uploading reports for the commit aa116ad to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #976      +/-   ##
==========================================
- Coverage   61.85%   61.81%   -0.05%     
==========================================
  Files         172      172              
  Lines       14086    14079       -7     
==========================================
- Hits         8713     8703      -10     
- Misses       4629     4631       +2     
- Partials      744      745       +1     
Flag Coverage Δ
unittests 61.81% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
x/participationrewards/types/submodule_liquid.go 22.22% <ø> (-31.95%) ⬇️
x/participationrewards/types/submodule_osmosis.go 46.83% <0.00%> (ø)
x/interchainquery/types/msgs.go 36.36% <0.00%> (-2.77%) ⬇️

@faddat faddat enabled auto-merge (squash) December 29, 2023 17:08
@faddat faddat merged commit 8ff511f into main Dec 29, 2023
13 checks passed
@joe-bowman joe-bowman deleted the fix/974-permit-unhyphenated-chain-id branch December 31, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChainId expected to contain a hyphen
2 participants