Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix interchaintest #965

Merged
merged 1 commit into from
Dec 27, 2023
Merged

fix interchaintest #965

merged 1 commit into from
Dec 27, 2023

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Dec 25, 2023

1. Summary

An earlier dependency update (maybe comet?) broke interchaintest. this fixes that.

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)

@faddat faddat requested a review from joe-bowman as a code owner December 25, 2023 08:43
@faddat faddat enabled auto-merge (squash) December 25, 2023 08:44
@faddat
Copy link
Contributor Author

faddat commented Dec 25, 2023

@joe-bowman I'll leave this one for your signoff sir. Think it should be great.

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b82256) 61.87% compared to head (06823a9) 61.87%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #965   +/-   ##
=======================================
  Coverage   61.87%   61.87%           
=======================================
  Files         172      172           
  Lines       14080    14080           
=======================================
  Hits         8712     8712           
  Misses       4623     4623           
  Partials      745      745           
Flag Coverage Δ
unittests 61.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@faddat faddat merged commit 1b7b10a into main Dec 27, 2023
16 checks passed
@joe-bowman joe-bowman deleted the faddat/fix-interchain-test branch December 27, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants