Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure we have standard 6 second blocks #938

Merged
merged 1 commit into from
Dec 24, 2023
Merged

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Dec 24, 2023

1. Summary

While two second blocks are great, we should not do that till we are on 50.

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

3. Implementation details

4. How to test/use

5. Checklist

  • Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

@faddat faddat requested a review from joe-bowman as a code owner December 24, 2023 12:46
@faddat faddat changed the title slow down some ensure we have standard 6 second blocks Dec 24, 2023
Copy link

codecov bot commented Dec 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f65560) 61.87% compared to head (8881dad) 61.87%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #938   +/-   ##
=======================================
  Coverage   61.87%   61.87%           
=======================================
  Files         172      172           
  Lines       14080    14080           
=======================================
  Hits         8712     8712           
  Misses       4623     4623           
  Partials      745      745           
Flag Coverage Δ
unittests 61.87% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/quicksilverd/root.go 58.90% <100.00%> (ø)

@faddat faddat enabled auto-merge (squash) December 24, 2023 15:29
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@faddat faddat merged commit 39b25ed into main Dec 24, 2023
9 of 10 checks passed
@joe-bowman joe-bowman deleted the faddat/take-foot-off-gas branch December 24, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants