Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependabout from Quicksilver.s and add depend about to web UI #922

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Dec 23, 2023

1. Summary

Just keeping dependabot happy

  • Bug fix (non-breaking change which fixes an issue)

@faddat faddat requested a review from joe-bowman as a code owner December 23, 2023 16:51
@faddat faddat enabled auto-merge (squash) December 23, 2023 16:51
Copy link

codecov bot commented Dec 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bbcab26) 61.87% compared to head (2cea1bf) 61.87%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #922   +/-   ##
=======================================
  Coverage   61.87%   61.87%           
=======================================
  Files         172      172           
  Lines       14080    14080           
=======================================
  Hits         8712     8712           
  Misses       4623     4623           
  Partials      745      745           
Flag Coverage Δ
unittests 61.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@faddat faddat merged commit 31f88f0 into main Dec 23, 2023
9 checks passed
@joe-bowman joe-bowman deleted the faddat/web-ui-dependabot branch December 23, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants