Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working UI Branch #919

Merged
merged 53 commits into from
Jan 3, 2024
Merged

Working UI Branch #919

merged 53 commits into from
Jan 3, 2024

Conversation

chalabi2
Copy link
Collaborator

1. Summary

Working draft PR for webui

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

3. Implementation details

This is the new Quivksilver Web-UI

4. How to test/use

cd web-ui
bun install
bun run dev

6. Limitations (optional)

This is still a WIP. This branch may be broken at times and should not be merged without review

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (28110da) 61.74% compared to head (a29317d) 61.74%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #919   +/-   ##
=======================================
  Coverage   61.74%   61.74%           
=======================================
  Files         172      172           
  Lines       14125    14125           
=======================================
  Hits         8721     8721           
  Misses       4656     4656           
  Partials      748      748           
Flag Coverage Δ
unittests 61.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@chalabi2 chalabi2 self-assigned this Dec 22, 2023
@chalabi2 chalabi2 added the webui label Dec 22, 2023
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

faddat
faddat previously approved these changes Dec 27, 2023
@faddat
Copy link
Contributor

faddat commented Dec 27, 2023

@chalabi2 if it's cool with you, I would like to get this one merged and in general merge it more routinely, so that I can begin work on embedding the user interface into the go applications so that the user interface becomes fully uncensorable.

web-ui/pages/_app.tsx Fixed Show fixed Hide fixed
@faddat
Copy link
Contributor

faddat commented Dec 29, 2023

@chalabi2 nope. Basically we just need to merge this branch. Then I will change the golang app so that:

  1. before the golang app is compiled in ci, we build the web app
  2. the output of the built web app is embedded in the chain's binary
  3. the web app is served from the files embedded in the chains binary.

So, basically at this point the ask is like:

  1. can we merge this branch?
  2. can we merge branches like this one more frequently in the future so that we can get the web app (even more) integrated in the ci flow?

Since the webapp you've made is just 100% static and needs only github pages, there's precisely zero constraints or changes to the webapp needed.

@chalabi2 chalabi2 marked this pull request as ready for review January 3, 2024 07:18
@chalabi2 chalabi2 requested a review from joe-bowman as a code owner January 3, 2024 07:18
@chalabi2
Copy link
Collaborator Author

chalabi2 commented Jan 3, 2024

@faddat you should be good to merge this, please keep in mind its still got some bugs and query errors, but we are getting there!

@joe-bowman joe-bowman merged commit 2916660 into main Jan 3, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants