Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI working branch #917

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Add UI working branch #917

merged 4 commits into from
Dec 20, 2023

Conversation

chalabi2
Copy link
Collaborator

@chalabi2 chalabi2 commented Dec 19, 2023

1. Summary

Add the bunDev working branch

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

4. How to test/use

bun install
bun run dev

6. Limitations (optional)

Uncomplete

@chalabi2 chalabi2 changed the title Add ui working branch Add UI working branch (BROKEN) Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (089ff5d) 61.87% compared to head (c56a4d0) 61.87%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #917   +/-   ##
=======================================
  Coverage   61.87%   61.87%           
=======================================
  Files         172      172           
  Lines       14080    14080           
=======================================
  Hits         8712     8712           
  Misses       4623     4623           
  Partials      745      745           
Flag Coverage Δ
unittests 61.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

- Deploy for quicksilver pages
@chalabi2
Copy link
Collaborator Author

chalabi2 commented Dec 20, 2023

@faddat We need the change to the workflow file for testing the deployment in this commit e67d18e merged.

@chalabi2
Copy link
Collaborator Author

Also, it probably wouldnt hurt to just merge this branch where every thing builds and works into main?

@chalabi2 chalabi2 changed the title Add UI working branch (BROKEN) Add UI working branch Dec 20, 2023
@faddat
Copy link
Contributor

faddat commented Dec 20, 2023 via email

@faddat
Copy link
Contributor

faddat commented Dec 20, 2023

@chalabi2 if you take this out of draft you should now be able to merge it :)

Seems the monorepo is working -- success in making smaller changesets :D

@chalabi2 chalabi2 marked this pull request as ready for review December 20, 2023 21:47
@chalabi2 chalabi2 requested a review from joe-bowman as a code owner December 20, 2023 21:47
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mergy mergy

@joe-bowman joe-bowman merged commit 7a9a58e into main Dec 20, 2023
11 checks passed
@joe-bowman joe-bowman deleted the bunDev branch December 20, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants