Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore changes to web-ui #916

Merged
merged 4 commits into from
Dec 20, 2023
Merged

ignore changes to web-ui #916

merged 4 commits into from
Dec 20, 2023

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Dec 19, 2023

1. Summary

Github actions slow down PR's to the web ui. This PR will resolve that by ignoring changes to the web-ui branch.

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

3. Implementation details

4. How to test/use

5. Checklist

  • Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

@faddat faddat requested a review from joe-bowman as a code owner December 19, 2023 22:43
@faddat faddat marked this pull request as draft December 19, 2023 22:43
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (089ff5d) 61.87% compared to head (b91e083) 61.87%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #916   +/-   ##
=======================================
  Coverage   61.87%   61.87%           
=======================================
  Files         172      172           
  Lines       14080    14080           
=======================================
  Hits         8712     8712           
  Misses       4623     4623           
  Partials      745      745           
Flag Coverage Δ
unittests 61.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@faddat faddat self-assigned this Dec 19, 2023
@faddat faddat marked this pull request as ready for review December 19, 2023 23:03
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks stonking.

@joe-bowman joe-bowman merged commit 5f11665 into main Dec 20, 2023
9 checks passed
@joe-bowman joe-bowman deleted the faddat/ignore-webui branch December 20, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants