-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove assets page #913
remove assets page #913
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #913 +/- ##
=======================================
Coverage 61.87% 61.87%
=======================================
Files 172 172
Lines 14080 14080
=======================================
Hits 8712 8712
Misses 4623 4623
Partials 745 745
Flags with carried forward coverage won't be shown. Click here to find out more. |
522a016
to
3d37016
Compare
@chalabi2 - after you review and merge this, it should be published to github pages. If it doesn't, lmk 🖖 |
I'll also make an issue so that CI for the chain doesn't slow down web dev... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removes assets page with no breaking changes
So long as the web-ui directory never depends on chain or js(npm packages only) stuff we should be okay. |
@chalabi2 the chain CI can take a long time to run, so I'm going to roll with it. Need to get your approvals a little more power, but I think we are moving good :)! |
This PR removes the assets page from the quicksilver webui, enabling it to build, and enabling us to test its deployment to github pages.