Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove assets page #913

Merged
merged 4 commits into from
Dec 19, 2023
Merged

remove assets page #913

merged 4 commits into from
Dec 19, 2023

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Dec 19, 2023

This PR removes the assets page from the quicksilver webui, enabling it to build, and enabling us to test its deployment to github pages.

@faddat faddat requested a review from joe-bowman as a code owner December 19, 2023 21:57
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a2b82c) 61.87% compared to head (522a016) 61.87%.

❗ Current head 522a016 differs from pull request most recent head 3d37016. Consider uploading reports for the commit 3d37016 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #913   +/-   ##
=======================================
  Coverage   61.87%   61.87%           
=======================================
  Files         172      172           
  Lines       14080    14080           
=======================================
  Hits         8712     8712           
  Misses       4623     4623           
  Partials      745      745           
Flag Coverage Δ
unittests 61.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@faddat faddat requested a review from chalabi2 as a code owner December 19, 2023 22:13
@faddat faddat force-pushed the faddat/remove-assets branch from 522a016 to 3d37016 Compare December 19, 2023 22:30
@faddat
Copy link
Contributor Author

faddat commented Dec 19, 2023

@chalabi2 - after you review and merge this, it should be published to github pages. If it doesn't, lmk 🖖

@faddat faddat mentioned this pull request Dec 19, 2023
1 task
@faddat
Copy link
Contributor Author

faddat commented Dec 19, 2023

I'll also make an issue so that CI for the chain doesn't slow down web dev...

Copy link
Collaborator

@chalabi2 chalabi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes assets page with no breaking changes

@chalabi2
Copy link
Collaborator

I'll also make an issue so that CI for the chain doesn't slow down web dev...

So long as the web-ui directory never depends on chain or js(npm packages only) stuff we should be okay.

@faddat
Copy link
Contributor Author

faddat commented Dec 19, 2023

@chalabi2 the chain CI can take a long time to run, so I'm going to roll with it. Need to get your approvals a little more power, but I think we are moving good :)!

@faddat faddat merged commit 135288e into main Dec 19, 2023
20 checks passed
@joe-bowman joe-bowman deleted the faddat/remove-assets branch December 27, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants