x/partiticipationrewards/types: assert on expected error substring in TestGetRewardsAllocations #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… TestGetRewardsAllocations This change makes TestGetRewardsAllocations more precise by asserting on expected error substrings instead of just expecting an error. This makes it that any future regressions that produce errors can be trivially sniffed out when tests fail. Fixes quicksilver-zone#831
faddat
approved these changes
Dec 10, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #832 +/- ##
===========================================
+ Coverage 14.45% 61.96% +47.51%
===========================================
Files 243 172 -71
Lines 63133 14028 -49105
===========================================
- Hits 9126 8693 -433
+ Misses 53251 4596 -48655
+ Partials 756 739 -17
Flags with carried forward coverage won't be shown. Click here to find out more. |
joe-bowman
pushed a commit
that referenced
this pull request
Dec 11, 2023
1 task
joe-bowman
pushed a commit
that referenced
this pull request
Dec 12, 2023
Co-authored-by: Jacob Gadikian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes TestGetRewardsAllocations more precise by asserting on expected error substrings instead of just expecting an error. This makes it that any future regressions that produce errors can be trivially sniffed out when tests fail.
Fixes #831