Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: icq-relayer v0.10.0; add tm0.37 compat #766

Merged
merged 3 commits into from
Nov 13, 2023
Merged

fix: icq-relayer v0.10.0; add tm0.37 compat #766

merged 3 commits into from
Nov 13, 2023

Conversation

joe-bowman
Copy link
Contributor

1. Summary

  • Fixes tm/comet v0.37 incompatibility in ICQ relayer
  • Bump versions
  • Changes module path based on monorepo inclusion

2.Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

3. Implementation details

This change replaces the call to RPCClient.Tx() with a local function that does not attempt to unmarshal the response, which is non-backward compatible between v0.34 and v0.37 (events are no longer base64 encoded, and are thusly stored as string instead of bytes).

The local function unmarshals into an struct containing only the proof and height fields (those we care about), and thus does not attempt to unmarshal the TxEvents.

4. How to test/use

Tested against Juno (tm0.37) and Txs now pass.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #766 (8d45dc8) into main (009d7ef) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 8d45dc8 differs from pull request most recent head 26fc5d8. Consider uploading reports for the commit 26fc5d8 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #766      +/-   ##
==========================================
- Coverage   14.45%   14.39%   -0.06%     
==========================================
  Files         243      243              
  Lines       63133    63127       -6     
==========================================
- Hits         9126     9089      -37     
- Misses      53251    53286      +35     
+ Partials      756      752       -4     
Flag Coverage Δ
unittests 14.39% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Copy link
Contributor

@ThanhNhann ThanhNhann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@ThanhNhann ThanhNhann merged commit f84d4bc into main Nov 13, 2023
9 checks passed
@ThanhNhann ThanhNhann deleted the icq-0.10.0 branch November 13, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants