Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit fix stylist #754

Merged
merged 5 commits into from
Oct 30, 2023
Merged

Conversation

sontrinh16
Copy link
Contributor

1. Summary

Fixes #611

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #754 (e8cb02a) into main (20bb508) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #754      +/-   ##
==========================================
- Coverage   14.01%   14.01%   -0.01%     
==========================================
  Files         243      243              
  Lines       63063    63060       -3     
==========================================
- Hits         8841     8838       -3     
  Misses      53508    53508              
  Partials      714      714              
Flag Coverage Δ
unittests 14.01% <83.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
x/interchainstaking/keeper/callbacks.go 53.09% <100.00%> (-0.19%) ⬇️
x/participationrewards/keeper/callbacks.go 44.19% <100.00%> (-0.13%) ⬇️
test/simulation/state.go 0.00% <0.00%> (ø)

Copy link
Contributor

@ThanhNhann ThanhNhann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@ThanhNhann ThanhNhann merged commit df252ef into quicksilver-zone:main Oct 30, 2023
@ThanhNhann ThanhNhann deleted the audit_fix_stylist branch October 30, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

all, x/interchainstaking/keeper: create and use variables closest to where they are used
2 participants