Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use safe quoting instead of \"%s\" #750

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

phamminh0811
Copy link
Contributor

1. Summary

Fixes #606

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

3. Implementation details

4. How to test/use

5. Checklist

  • Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

Copy link
Contributor

@anhductn2001 anhductn2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #750 (e5f49d2) into main (8d361ad) will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #750   +/-   ##
=======================================
  Coverage   14.00%   14.00%           
=======================================
  Files         243      243           
  Lines       63049    63049           
=======================================
  Hits         8832     8832           
  Misses      53503    53503           
  Partials      714      714           
Flag Coverage Δ
unittests 14.00% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
x/interchainstaking/keeper/keeper.go 74.84% <33.33%> (ø)

@ThanhNhann ThanhNhann merged commit 9d69d78 into main Oct 30, 2023
12 checks passed
@ThanhNhann ThanhNhann deleted the minh/quote-get-chain-id branch October 30, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants