Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for GovReopenChannel #725

Merged

Conversation

DongLieu
Copy link
Contributor

1. Summary

Fixes #617

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

3. Implementation details

4. How to test/use

5. Checklist

  • Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #725 (ea6c7da) into main (0af6442) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #725      +/-   ##
==========================================
+ Coverage   13.78%   13.85%   +0.06%     
==========================================
  Files         243      243              
  Lines       63047    63047              
==========================================
+ Hits         8694     8735      +41     
+ Misses      53642    53602      -40     
+ Partials      711      710       -1     
Flag Coverage Δ
unittests 13.85% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@joe-bowman
Copy link
Contributor

This test only checks that there was not an error. What is the function doing? How can we assert this?

@DongLieu
Copy link
Contributor Author

For example, the port connection has been set correctly

@joe-bowman
Copy link
Contributor

@DongLieu - looks good - can you resolve the conflicts please?

@DongLieu
Copy link
Contributor Author

Ok, thank joe-bowman

@ThanhNhann ThanhNhann merged commit 64173b8 into quicksilver-zone:main Oct 26, 2023
11 checks passed
@ThanhNhann ThanhNhann deleted the dong/TestGovReopenChannel branch October 26, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants