Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check stateless ICAAccount #719

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

ThanhNhann
Copy link
Contributor

1. Summary

Fixes #700

  • Update stateless check for DecrementBalanceWaitgroup func

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

3. Implementation details

4. How to test/use

5. Checklist

  • Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #719 (d3eae3f) into main (7521baa) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #719   +/-   ##
=======================================
  Coverage   13.40%   13.40%           
=======================================
  Files         243      243           
  Lines       63047    63047           
=======================================
  Hits         8450     8450           
  Misses      53919    53919           
  Partials      678      678           
Flag Coverage Δ
unittests 13.40% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
x/interchainstaking/types/accounts.go 100.00% <100.00%> (ø)

Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will have no functional change, but for the sake of correctness, lgtm.

@joe-bowman joe-bowman merged commit 8198456 into main Oct 23, 2023
12 checks passed
@joe-bowman joe-bowman deleted the nhan/update_stateless_ICAAccount branch November 7, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BalanceWaitgroup can not smaller than 0
3 participants