Test for RemoveZoneAndAssociatedRecords

[DongLieu]

1. Summary

Fixes #617

2.Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

3. Implementation details

4. How to test/use

5. Checklist

• Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

[codecov]

Codecov Report

Merging #678 (e120b08) into main (963ffa9) will increase coverage by 0.05%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #678      +/-   ##
==========================================
+ Coverage   14.39%   14.44%   +0.05%     
==========================================
  Files         243      243              
  Lines       63127    63133       +6     
==========================================
+ Hits         9089     9122      +33     
+ Misses      53286    53255      -31     
- Partials      752      756       +4     

Flag	Coverage Δ
unittests	14.44% <66.66%> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
x/interchainstaking/keeper/validators.go	93.15% <ø> (ø)
x/interchainstaking/keeper/zones.go	62.11% <66.66%> (+7.12%)	⬆️

[joe-bowman]

Can we also check for validators / receipts / withdrawal records etc. by zone to ensure that everything that should have been cleaned up has been? thankjs,

[DongLieu]

Ok

[DongLieu]

@joe-bowman
Cannot check:

• delegation records: because the zone has been deleted

• performance delegation records: because the zone has been deleted

• validators: In the RemoveZoneAndAssociatedRecords function do not remove Validator. Set add validators to create related

Additional:
In GetReceipt, I think we should pass by value: 'chainID' and 'TxHash' instead of the current 'key' .PR:#735

[joe-bowman]

Validators should definitely be removed if a zone is removed. Can you make a fix for this, please?

Validator storage changed in v1.4 and the deletion of validators for a given zone was almost certainly overlooked.

[joe-bowman]

• delegation records: because the zone has been deleted
• performance delegation records: because the zone has been deleted

Also probably a good time to refactor:

k.IterateAllDelegations(ctx, zone, func(delegation types.Delegation) (stop bool) {
k.IterateAllPerformanceDelegations(ctx, zone, func(delegation types.Delegation) (stop bool) {
k.IterateZoneReceipts(ctx, zone, func(index int64, receiptInfo types.Receipt) (stop bool) {

to take chainID instead of zone (all three methods only make use of zone.ChainID internally anyway!) but allows us to assert the removal properly.

This also ensures the signatures are consistent with the other types (withdrawals, unbonding and redelegation records), and allows us to remove the unnecessary IterateZones call in the function being tested!

[DongLieu]

Okay,
Do I create a new PR to do this, or do it in this PR?

[DongLieu]

For checks delegation and performance delegation records, I need to wait for the pull #748 to be merged

[DongLieu]

I need to merge this PR #758 first, please review it

[DongLieu]

Ok, done. @ThanhNhann @joe-bowman

[anhductn2001]

Nice works @DongLieu !

[joe-bowman]

lgtm