Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for GetActiveValidators #675

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Test for GetActiveValidators #675

merged 5 commits into from
Oct 26, 2023

Conversation

phamminh0811
Copy link
Contributor

1. Summary

Fixes #617

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

3. Implementation details

4. How to test/use

5. Checklist

  • Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #675 (d72c8f3) into main (1ed5da2) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #675      +/-   ##
==========================================
+ Coverage   13.67%   13.68%   +0.01%     
==========================================
  Files         243      243              
  Lines       63047    63047              
==========================================
+ Hits         8620     8628       +8     
+ Misses      53724    53716       -8     
  Partials      703      703              
Flag Coverage Δ
unittests 13.68% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

joe-bowman
joe-bowman previously approved these changes Oct 17, 2023
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@phamminh0811
Copy link
Contributor Author

@ThanhNhann could you check this pr for me so that we can merge it

Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joe-bowman joe-bowman merged commit 79bca15 into main Oct 26, 2023
9 checks passed
@joe-bowman joe-bowman deleted the minh/get-active-validators branch October 26, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants