Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DistributeRewardsCallback Test #653

Merged
merged 16 commits into from
Oct 26, 2023
Merged

Conversation

phamminh0811
Copy link
Contributor

1. Summary

Fixes #617

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

3. Implementation details

4. How to test/use

5. Checklist

  • Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #653 (3cf1e10) into main (64173b8) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #653      +/-   ##
==========================================
+ Coverage   13.85%   13.95%   +0.10%     
==========================================
  Files         243      243              
  Lines       63047    63047              
==========================================
+ Hits         8735     8800      +65     
+ Misses      53602    53537      -65     
  Partials      710      710              
Flag Coverage Δ
unittests 13.95% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@joe-bowman
Copy link
Contributor

A couple of questions, and also linting required.

@phamminh0811
Copy link
Contributor Author

Oh, my bad. I forgot deleting debug stuffs. Will fix it later

@joe-bowman
Copy link
Contributor

Just linting ser :)

@phamminh0811
Copy link
Contributor Author

Done, please check

x/interchainstaking/keeper/callbacks_test.go Outdated Show resolved Hide resolved
x/interchainstaking/keeper/callbacks_test.go Outdated Show resolved Hide resolved
x/interchainstaking/keeper/callbacks_test.go Outdated Show resolved Hide resolved
@ThanhNhann
Copy link
Contributor

Plz fix the conflict then we can merge this pr. We also have to make interchaintest for this function @anhductn2001

Copy link
Contributor

@ThanhNhann ThanhNhann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joe-bowman joe-bowman merged commit 8d735b0 into main Oct 26, 2023
@joe-bowman joe-bowman deleted the minh/distribute-rewards-callback branch October 26, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants