-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DistributeRewardsCallback Test #653
Conversation
Codecov Report
@@ Coverage Diff @@
## main #653 +/- ##
==========================================
+ Coverage 13.85% 13.95% +0.10%
==========================================
Files 243 243
Lines 63047 63047
==========================================
+ Hits 8735 8800 +65
+ Misses 53602 53537 -65
Partials 710 710
Flags with carried forward coverage won't be shown. Click here to find out more. |
A couple of questions, and also linting required. |
Oh, my bad. I forgot deleting debug stuffs. Will fix it later |
…/quicksilver-zone/quicksilver into minh/distribute-rewards-callback
Just linting ser :) |
Done, please check |
Plz fix the conflict then we can merge this pr. We also have to make interchaintest for this function @anhductn2001 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
1. Summary
Fixes #617
2.Type of change
3. Implementation details
4. How to test/use
5. Checklist
6. Limitations (optional)
7. Future Work (optional)