Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for GCCompletedRedelegations #652

Merged
merged 5 commits into from
Sep 28, 2023
Merged

Test for GCCompletedRedelegations #652

merged 5 commits into from
Sep 28, 2023

Conversation

phamminh0811
Copy link
Contributor

1. Summary

Fixes #617

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

3. Implementation details

4. How to test/use

5. Checklist

  • Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #652 (7f3b1b6) into main (8fc6f20) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #652      +/-   ##
==========================================
+ Coverage   13.19%   13.21%   +0.02%     
==========================================
  Files         243      243              
  Lines       62951    62951              
==========================================
+ Hits         8308     8322      +14     
+ Misses      53974    53960      -14     
  Partials      669      669              
Flag Coverage Δ
unittests 13.21% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Copy link
Contributor

@ThanhNhann ThanhNhann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@phamminh0811
Copy link
Contributor Author

@joe-bowman could you check this pr for me?

Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joe-bowman joe-bowman merged commit a02415f into main Sep 28, 2023
@joe-bowman joe-bowman deleted the minh/gcc branch September 28, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants