finish linting #568
Merged
finish linting #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faddat
requested review from
joe-bowman,
ajansari95,
muku314115,
ThanhNhann,
sontrinh16 and
anhductn2001
as code owners
Codecov Report
@@ Coverage Diff @@
## main #568 +/- ##
=======================================
Coverage 13.19% 13.19%
=======================================
Files 243 243
Lines 62942 62948 +6
=======================================
+ Hits 8306 8309 +3
- Misses 53967 53970 +3
Partials 669 669
Flags with carried forward coverage won't be shown. Click here to find out more.
|
anhductn2001
approved these changes
Sep 15, 2023
ThanhNhann
reviewed
Sep 15, 2023
| // add unallocated dust. | ||
| msgs[0].Amount = msgs[0].Amount.AddAmount(outstanding) | ||
| // Ensure there are messages to process | ||
| if len(msgs) > 0 { |
There was a problem hiding this comment.
I think we don't need to check the len(msgs) here because it always > 0 if the code can run here, just need to add //nolint:gosec to pass the lint
| @@ -294,7 +294,7 @@ func (suite *KeeperTestSuite) TestCalcDistributionScores() { | |||
| validators := appA.InterchainstakingKeeper.GetValidators(ctx, zone.ChainId) | |||
| for i := range validators { | |||
| validators[i].VotingPower = sdk.NewInt(0) | |||
| appA.InterchainstakingKeeper.SetValidator(ctx, zone.ChainId, validators[i]) | |||
| appA.InterchainstakingKeeper.SetValidator(ctx, zone.ChainId, validators[i]) //nolint:errcheck // ignore error | |||
There was a problem hiding this comment.
Why we don't check the error here
| @@ -329,7 +329,7 @@ func (suite *KeeperTestSuite) TestCalcDistributionScores() { | |||
|
|
|||
| for i, val := range appA.InterchainstakingKeeper.GetValidators(ctx, zone.ChainId) { | |||
| val.VotingPower = sdk.NewInt(int64(10 + i*10)) | |||
| appA.InterchainstakingKeeper.SetValidator(ctx, zone.ChainId, val) | |||
| appA.InterchainstakingKeeper.SetValidator(ctx, zone.ChainId, val) //nolint:errcheck // ignore error | |||
There was a problem hiding this comment.
Same above, why we don't check the error for this?
|
Will re-address tomorrow. Thanks for the review, @ThanhNhann |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Summary
Resolves all linter issues
closes: #550
2.Type of change
3. Implementation details
Resolve all linter issues