Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New quicksilverjs using grpc-gateway #566

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Conversation

hoangdv2429
Copy link
Contributor

@hoangdv2429 hoangdv2429 commented Sep 15, 2023

1. Summary

This PR contains a massively updated quicksilver-js.

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

3. Implementation details

4. How to test/use

from README.md but using createGrpcGatewayClient instead of the one in the manual.

5. Checklist

  • update README
  • testing using jest/spec
  • fix eslint/type errors.
  • fix camelCase and snake_case compability.

6. Limitations (optional)

7. Future Work (optional)

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #566 (cb8bb0a) into develop (a28e49a) will not change coverage.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #566   +/-   ##
========================================
  Coverage    13.19%   13.19%           
========================================
  Files          243      243           
  Lines        62942    62942           
========================================
  Hits          8306     8306           
  Misses       53967    53967           
  Partials       669      669           
Flag Coverage Δ
unittests 13.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@faddat faddat changed the base branch from develop to main September 15, 2023 09:00
@faddat faddat marked this pull request as ready for review September 15, 2023 10:15
@chalabi2
Copy link
Collaborator

@hoangdv2429 can you provide a little more insight here

fix eslint/type errors.
fix camelCase and snake_case compability

maybe an example of those issues.

@hoangdv2429
Copy link
Contributor Author

what I mean by that is fixing telescope:

  1. there are some type errors in the library (mostly with Timestamp, could just change it to Date so Typescript won't complain about it). but if we fix it, we'll fix it in Telescope. It still work, but I just get annoyed by those red mark.
  2. for example, when you're querying for delegationUnbonding the type of delegationUnbonding is delegateAddress and validatorAddress but the actual fm.renderURL is using delegate_address and validator_address. (this is only an example, could not 100% named like this)
    All of those errors should be fix in telescope and then regen the library.

@hoangdv2429
Copy link
Contributor Author

Screenshot 2023-09-17 at 13 46 26 take this as an example.

@joe-bowman joe-bowman deleted the feat/new_quicksilverjs branch November 7, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants