Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buf fixes for crescent address decoding and test file updates #524

Merged
merged 4 commits into from
Aug 7, 2023

Conversation

muku314115
Copy link
Contributor

1. Summary

Fixes # (issue)

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

3. Implementation details

4. How to test/use

5. Checklist

  • Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2023

Codecov Report

Merging #524 (55cd9e7) into develop (7135ac9) will decrease coverage by 0.01%.
The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #524      +/-   ##
===========================================
- Coverage    53.65%   53.64%   -0.01%     
===========================================
  Files          186      186              
  Lines        14635    14627       -8     
===========================================
- Hits          7852     7847       -5     
+ Misses        6126     6124       -2     
+ Partials       657      656       -1     
Flag Coverage Δ
unittests 53.64% <28.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
x/participationrewards/keeper/msg_server.go 76.59% <ø> (ø)
x/participationrewards/types/submodule_crescent.go 22.85% <0.00%> (-3.07%) ⬇️
x/participationrewards/keeper/callbacks.go 44.31% <25.00%> (-0.31%) ⬇️
.../participationrewards/keeper/submodule_crescent.go 74.76% <100.00%> (ø)

Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ajansari95 ajansari95 merged commit 7708327 into develop Aug 7, 2023
@ajansari95 ajansari95 deleted the mukund/redundancy branch August 7, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants