Upgrade ictest and add register-zone test #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anhductn2001
requested review from
joe-bowman,
ajansari95,
aljo242,
muku314115 and
cybertronprime
as code owners
|
@anhductn2001 why are we using the |
Because we cannot use flag |
Can you update your fork to the latest version of interchaintest? This will include the sidecar functionality? Is there a PR opened against interchaintest for your fix for |
|
yes, @ThanhNhann had a discussion to remove |
|
In the sdk47 of unstable-v1.5 we dont use crisis so @anhductn2001 have to make a fork, I think you should make a pr to interchaintest for this update @anhductn2001 |
|
Hey @aljo242 , I just update fork to latest version. |
|
lint failing. Please run |
aljo242
reviewed
Aug 9, 2023
Codecov Report
@@ Coverage Diff @@
## unstable-v1.5 #521 +/- ##
================================================
Coverage ? 53.00%
================================================
Files ? 189
Lines ? 15343
Branches ? 0
================================================
Hits ? 8132
Misses ? 6543
Partials ? 668
Flags with carried forward coverage won't be shown. Click here to find out more. |
ThanhNhann
added a commit
to notional-labs/quicksilver
that referenced
this pull request
Aug 16, 2023
|
@anhductn2001 conflicts |
aljo242
pushed a commit
that referenced
this pull request
Aug 17, 2023
* sdk 47 * cleanup * use wasmd 47 * cosmossdk.io/simapp * use lsm sdk 47 * update pruning & distclient paths * intergrate with sdk47 => using ibc v7.0.0 * tendermint/spm/ibckeeper -> ibc-go/v7/ibckeeper * update packet forward moiddleware to v7 * tendermint -> comebft * fix keepers: ConsensusParamsKeeper, add logger to InitKeepers, NewCommunityPoolSpendProposalHandler no longer available * fix app.go * upgrade handler from v46 => v47 * fix cometbft path * fix app folder * fix cmd & wasm * need to cast type * fix x/ modules * fix iavl conflict version: use 0.20.0 * gogoproto => cosmos proto * add consensusparams & crisiskeeper keys * add tendermint appmodulebasic and set baseapp chain id in test setup * move set baseapp chainID in if nest * add govrouter to gov module legacy router and add checksum in test submit wasm prop * add checksum * change testchainID * using icaControllerKeeper msg_server for registerInterchainAccount and SendTx * clean up * fix zone test * restore app_test.go * fix testcase * move get context * Update app/config.go Co-authored-by: Alex Johnson <[email protected]> * minor clean up * revert * resolve some reviews * fix install err * lint * fix lint * add port to unstable rule (#450) (#454) (cherry picked from commit 200abd5) Co-authored-by: Alex Johnson <[email protected]> * fix last test * fix port owner * lint * Pr tvl updates (#445) * front-port v1.2.13 * fix delegation flush test * add tests for HandleDepositTransaction * update tests for new error handling * remove superflous field in proto * final v1.2.13 front-port and test fixes * s/s/suite/ * remove fmt.Printlns used for debugging * update participation rewards and protocoldatas, to add validation, automatic key generation, basechain/basedenom in osmosisparams and updated tvl calculation * front-port v1.2.13 * remove balancerPoolPretty json marshal/unmarshal, as we deal with raw KV store objects; switch to native bech32 decode/encode as we dont expect prefix of pools to match sdk.GetConfig().Bech32Prefix * fix: allow support for multiple denoms from same zone in tvl calc * lint * fix: refactor utils/address.go to avoid import cycle when using in osmosis-types * add test for randomutils * fix: remove potential non-det by iterating over maps using sorted keys * resolve outstanding nits * lint * fix nits * bump go to 1.20.5 * Update x/interchainstaking/keeper/receipt.go * Apply suggestions from code review * lint * bump hermes to v1.5.0 * update icq and relayer in test scripts * format and update * fix makefile * remove legacy * remove legacy param sim * fix hard code * remove gogo * update ibc-go * remove * format * remove deprecated * remove * fix * zones helpers * zones helpers * remove hard code for owner field * use proper replaces * make note for nolint * make note for nolint * use proper broadcast mode in test * make note for nolint * make note for nolint * add error check * clean * fix proto-gen * update protobuf make file * proto-gen-swagger * fix make build-docker * fix warning proto * fix gen * fix set chainID * lint * ensure grpc port is opened for connections from other docker containers * add register node grpc * banktypes * correct goleveldb ver * add SetOrderExportGenesis * proposal need title and summary * update registerzone bash test * update govkeeper * Bump Interchain-test v7 for sdk47 * del duplicate sethook gov * add a check for claimed capability in SubmitTX * add register-zone ictest * fix interchaintest * use submit-proposal * update amount deposit * quicksilverEncoding * setup params * rm go.work.sum * add claim chancap in createChannelICA test setup * add err check * proposal struct * lint * fix lint * add register_zone_test * go mod tidy * set ICS module * remove scope * chore: clean duplicate and unused * add consensus module * fix can not register ICA * seperate interchaintest to pr #521 * clean code commented * revert SendTokenIBC func * fix error when run make test-docker-regen * fix check lint error --------- Co-authored-by: Hieu Vu <[email protected]> Co-authored-by: sontrinh16 <[email protected]> Co-authored-by: Alex Johnson <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: ThanhNhann <[email protected]> Co-authored-by: Joe Bowman <[email protected]> Co-authored-by: ducnt131 <[email protected]> Co-authored-by: catShaark <[email protected]>
|
@aljo242 is this required now after rightway merge? |
1 task
anhductn2001
requested review from
aljo242 and
ThanhNhann
and removed request for
cybertronprime and
aljo242
ThanhNhann
approved these changes
Sep 14, 2023
Can you try to pull and run the test again? because I see no warning related to Makefile. We seem to have fixed the warnings related to proto in PR upgrade to 47. The important thing now is that the migration of repo to new organization name in unstable branch has not been done. Maybe I'll do it today. @ThanhNhann |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Summary
3. Implementation details
github.com/strangelove-ventures/interchaintest/v7 => github.com/notional-labs/interchaintest/v7deposit_address4. How to test/use
make ictest-rz