Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #519

Merged
merged 5 commits into from
Aug 2, 2023
Merged

Fixes #519

merged 5 commits into from
Aug 2, 2023

Conversation

joe-bowman
Copy link
Contributor

1. Summary

  • Fixes panic on reward allocation in address creation race condition
    • Wrap statement in if ... != nil
  • Fixes ICS rewards distribution where multiple transfer channels exist.
    • Ensure we check for STATE_OPEN
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@codecov-commenter
Copy link

Codecov Report

Merging #519 (c001e25) into develop (204ea95) will increase coverage by 0.00%.
The diff coverage is 28.57%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #519   +/-   ##
========================================
  Coverage    53.64%   53.65%           
========================================
  Files          186      186           
  Lines        14634    14635    +1     
========================================
+ Hits          7851     7852    +1     
  Misses        6126     6126           
  Partials       657      657           
Flag Coverage Δ
unittests 53.65% <28.57%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
x/participationrewards/keeper/rewards_holdings.go 82.35% <16.66%> (+0.17%) ⬆️
x/interchainstaking/keeper/ibc_packet_handlers.go 41.70% <100.00%> (ø)

@ajansari95 ajansari95 merged commit 68e3ac7 into develop Aug 2, 2023
@ajansari95 ajansari95 deleted the fixes branch August 2, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants