Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove usage of suite.Require() in tests #511

Merged
merged 7 commits into from
Aug 1, 2023
Merged

Conversation

aljo242
Copy link

@aljo242 aljo242 commented Jul 21, 2023

replace suite.Require().* with suite.* since it is a bit cleaner and the Require() is totally unnecessary

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

Merging #511 (59377d7) into develop (2618ab0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #511   +/-   ##
========================================
  Coverage    53.64%   53.64%           
========================================
  Files          186      186           
  Lines        14634    14634           
========================================
  Hits          7851     7851           
  Misses        6126     6126           
  Partials       657      657           
Flag Coverage Δ
unittests 53.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aljo242 aljo242 merged commit 204ea95 into develop Aug 1, 2023
@aljo242 aljo242 deleted the chore/require branch August 1, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants