update intent to use defaults as fallback when vp has not claimed #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-bowman
requested review from
ajansari95,
aljo242,
muku314115 and
cybertronprime
as code owners
aljo242
reviewed
Jul 19, 2023
|
Yes tests are incoming.
On Wed, 19 Jul 2023 at 14:41, Alex Johnson ***@***.***> wrote:
***@***.**** commented on this pull request.
Can we add test for this? or refactor out and test new logic?
—
Reply to this email directly, view it on GitHub
<#510 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABA7QYA5RUTGA5D7UKMXYQLXQ7PZFANCNFSM6AAAAAA2O5YS2Y>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
*Joe Bowman*
CEO, Ingenuity
Founder, Quicksilver Protocol
***@***.***
|
Codecov Report
@@ Coverage Diff @@
## develop #510 +/- ##
===========================================
+ Coverage 56.30% 56.46% +0.16%
===========================================
Files 169 169
Lines 13188 13196 +8
===========================================
+ Hits 7425 7451 +26
+ Misses 5173 5157 -16
+ Partials 590 588 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Summary
Ensure given user does not exercise disproportionate power over aggregateIntent with small number of claims.